Optional deps #61
Merged
Optional deps #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabe-l-hart
force-pushed
the
OptionalDeps
branch
from
2608cd5
to
196de92
Compare
Signed-off-by: Gabe Goodhart <[email protected]>
This will detect when an import statement is guarded by a try/except and decorate the output of track_module with "optional": bool to indicate this. The indication is an aggregate, so if there are three sources for a given dependency, the "optional" field is only set to True if all three are optional. Signed-off-by: Gabe Goodhart <[email protected]>
Signed-off-by: Gabe Goodhart <[email protected]>
Signed-off-by: Gabe Goodhart <[email protected]>
Signed-off-by: Gabe Goodhart <[email protected]>
…ional deps cases Signed-off-by: Gabe Goodhart <[email protected]>
This gives full flexibilty to library owners to tweak which optional deps are kept, but defaults to not keeping any Signed-off-by: Gabe Goodhart <[email protected]>
…ps sample lib This will be used to ensure that try blocks are closed correctly Signed-off-by: Gabe Goodhart <[email protected]>
Signed-off-by: Gabe Goodhart <[email protected]>
Honestly not sure what happened here, but it seems that a plain -s is no longer enough to show logs Signed-off-by: Gabe Goodhart <[email protected]>
…nal when the direct dep is held as optional Signed-off-by: Gabe Goodhart <[email protected]>
Signed-off-by: Gabe Goodhart <[email protected]>
gabe-l-hart
force-pushed
the
OptionalDeps
branch
from
e21a5bd
to
39f99b1
Compare
Signed-off-by: Gabe Goodhart <[email protected]>
gabe-l-hart
commented
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.